Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: enforce shouldColorize in styleText array arg #56722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

util: enforce shouldColorize in styleText array arg #56722

wants to merge 1 commit into from

Conversation

marco-ippolito
Copy link
Member

Fixes: #56717

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (50d405a) to head (0477278).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56722      +/-   ##
==========================================
- Coverage   89.22%   89.21%   -0.01%     
==========================================
  Files         663      663              
  Lines      191974   191963      -11     
  Branches    36926    36923       -3     
==========================================
- Hits       171286   171269      -17     
- Misses      13561    13565       +4     
- Partials     7127     7129       +2
Files with missing lines Coverage Δ
lib/util.js 97.71% <100.00%> (-0.06%) ⬇️

... and 38 files with indirect coverage changes

@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64660/

fisker
fisker reviewed Jan 24, 2025
View reviewed changes
lib/util.js Outdated Show resolved Hide resolved
fisker
fisker reviewed Jan 24, 2025
View reviewed changes
lib/util.js Outdated Show resolved Hide resolved
@marco-ippolito marco-ippolito force-pushed the fix-color-style-trxt branch 3 times, most recently from 4599cad to d4b5727 Compare January 25, 2025 11:23
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64805/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisker fisker fisker left review comments

@deokjinkim deokjinkim deokjinkim approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

util.styleText is not respecting NO_COLOR when first argument is an array.
5 participants
@marco-ippolito @nodejs-github-bot @fisker @jasnell @deokjinkim